Adding test cases for primary key evaluation for complex composite views - #552
Merged
Ayush Agarwal (ayush3797) merged 37 commits intoJul 28, 2022
Merged
Conversation
Ayush Agarwal (ayush3797)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Aaron Powell (aaronpowell),
Abhishek Kumar (abhishekkumams),
Gledis Zeneli (gledis69),
Jarupat Jisarojito (jarupatj),
Jun Su (junsu0ms),
Bhaskar Mallapragada (mbhaskar),
Milis (milismsft),
Sean Leonard (seantleonard),
swviswan and
tarazou9
as code owners
July 13, 2022 15:56
Ayush Agarwal (ayush3797)
changed the title
Jarupat Jisarojito (jarupatj)
suggested changes
Jul 13, 2022
Aniruddh Munde (Aniruddh25)
requested changes
Jul 15, 2022
Aniruddh Munde (Aniruddh25)
left a comment
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
Waiting on using Assert.ThrowsException
Ayush Agarwal (ayush3797)
changed the title
added 4 commits
July 25, 2022 12:06
…ithub.com/Azure/hawaii-gql into dev/agarwalayush/BootStrapFailureTestCase
…StrapFailureTestCase
Jarupat Jisarojito (jarupatj)
suggested changes
Jul 25, 2022
Jarupat Jisarojito (jarupatj)
left a comment
Jarupat Jisarojito (jarupatj)
left a comment
Contributor
There was a problem hiding this comment.
Add comments.
Jarupat Jisarojito (jarupatj)
suggested changes
Jul 26, 2022
Sean Leonard (seantleonard)
previously requested changes
Jul 26, 2022
Sean Leonard (seantleonard)
left a comment
Sean Leonard (seantleonard)
left a comment
Contributor
There was a problem hiding this comment.
Couple questions prior to merge.
Aniruddh Munde (Aniruddh25)
approved these changes
Jul 27, 2022
Jarupat Jisarojito (jarupatj)
suggested changes
Jul 28, 2022
Jarupat Jisarojito (jarupatj)
approved these changes
Jul 28, 2022
Ayush Agarwal (ayush3797)
enabled auto-merge (squash)
July 28, 2022 18:26
Ayush Agarwal (ayush3797)
dismissed
Sean Leonard (seantleonard)’s stale review
July 28, 2022 18:27
All comments addressed.
Ayush Agarwal (ayush3797)
deleted the
dev/agarwalayush/BootStrapFailureTestCase
branch
July 28, 2022 18:27
Sean Leonard (seantleonard)
left a comment
Sean Leonard (seantleonard)
left a comment
Contributor
There was a problem hiding this comment.
some nits and questions to consider for follow-up.
Ayush Agarwal (ayush3797)
restored the
dev/agarwalayush/BootStrapFailureTestCase
branch
July 31, 2022 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a test cases to affirm that an appropriate exception is thrown when the primary key for a view cannot be determined, and pass the bootstrap in case if it can be determined.
Please refer to this issue : #404
The fix was already provided in this PR: #414